Re: static assert cleanup

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-12-15T09:32:27Z
Lists: pgsql-hackers
On 09.12.22 11:01, John Naylor wrote:
> 
> On Fri, Dec 9, 2022 at 2:47 PM Peter Eisentraut 
> <peter.eisentraut@enterprisedb.com 
> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
>  >
>  > 0003-Move-some-static-assertions-to-better-places.patch
>  >
>  > This moves some that I thought were suboptimally placed but it could be
>  > debated or refined.
> 
> + * We really want ItemPointerData to be exactly 6 bytes.  This is rather a
> + * random place to check, but there is no better place.
> 
> Since the assert is no longer in a random function body, it seems we can 
> remove the second sentence.

Committed with the discussed adjustments.




Commits

  1. Static assertions cleanup

  2. Rearrange some static assertions for consistency