Re: assorted code cleanup
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Ryan Murphy <ryanfmurphy@gmail.com>, pgsql-hackers@postgresql.org
Date: 2017-09-05T19:08:50Z
Lists: pgsql-hackers
On 8/29/17 03:32, Ryan Murphy wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: tested, passed > > I've reviewed the code changes, and it's pretty clear to me that they clean things up a bit while not changing any behavior. They simplify things in a way that make the code more comprehensible. I've run all the tests and they behave the same way as they did before the patch. I also trying manually playing around the the function in question, `metaphone`, and it seems to behave the same as before. > > I think it's ready to commit! > > The new status of this patch is: Ready for Committer Pushed, except the one with the function pointers, which some people didn't like. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Reduce excessive dereferencing of function pointers
- 1356f78ea933 11.0 landed