Re: pg_execute_from_file review

eggyknap <eggyknap@gmail.com>

From: Joshua Tolley <eggyknap@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Andrew Dunstan <andrew@dunslane.net>, Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, pgsql-hackers@postgresql.org

Date: 2010-11-29T16:18:13Z

Lists: pgsql-hackers

On Mon, Nov 29, 2010 at 11:12:58AM -0500, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > I'm not sure why you need either "from". It just seems like a noise 
> > word. Maybe we could use pg_execute_query_file() and 
> > pg_execute_query_string(), which would be fairly clear and nicely 
> > symmetrical.
> 
> +1, but I think "query" is also a noise word here.
> Why not just "pg_execute_file" and "pg_execute_string"?
> 
> 			regards, tom lane

While we're bikeshedding, and since I started the thread that has become this
topic, +1 for Tom's naming.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com