Horton

Re: Make all Perl warnings fatal

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-08-23T19:05:43Z
Lists: pgsql-hackers 
On 21.08.23 17:51, Andrew Dunstan wrote:
> Still, I guess that might not matter too much since apart from plperl we 
> only use perl for building / testing.
> 
> Regarding the dangers mentioned, I guess we can undo it if it proves a 
> nuisance.
> 
> +1 to getting rid if the unnecessary call to getprotobyname().

I have committed the latter part.

The rest would still depend on some fixes for the MSVC build system, so 
I'll hold that until we decide what to do with that.

Commits

  1. Add missing FATAL => 'all' to a use warnings in Perl

  2. Make all Perl warnings fatal in 043_wal_replay_wait.pl

  3. Add tap test for pg_signal_autovacuum role

  4. Implement pg_wal_replay_wait() stored procedure

  5. Fix an issue in PostgreSQL::Test::Cluster:psql()

  6. Make all Perl warnings fatal

  7. Fix a warning in Perl test code

  8. Avoid use of Perl getprotobyname