Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Jim Jones <jim.jones@uni-muenster.de>

From: Jim Jones <jim.jones@uni-muenster.de>

To: Manni Wood <manni.wood@enterprisedb.com>

Cc: Nishant Sharma <nishant.sharma@enterprisedb.com>, Álvaro Herrera <alvherre@kurilemu.de>, pgsql-hackers@postgresql.org

Date: 2025-11-08T00:03:08Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add infrastructure for pg_get_*_ddl functions
- 4881981f9202 19 (unreleased) landed
Add pg_get_tablespace_ddl() function
- b99fd9fd7f36 19 (unreleased) landed
Split out innards of pg_tablespace_location()
- 877a024902a7 19 (unreleased) landed
Remove spclocation field from pg_tablespace
- 16d8e594acd9 9.2.0 cited


On 08/11/2025 00:38, Manni Wood wrote:
> Alas, the build https://commitfest.postgresql.org/patch/6175/ <https://
> commitfest.postgresql.org/patch/6175/> now fails, and I cannot reproduce
> on my machine. Obviously there will be a v9...

You forgot the declaration for build_tablespace_ddl_string[1]:

ruleutils.c:13755:1: warning: no previous prototype for
‘build_tablespace_ddl_string’ [-Wmissing-prototypes]
13755 | build_tablespace_ddl_string(const Oid tspaceoid)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Best, Jim

1 - https://cirrus-ci.com/task/4855404196265984?logs=build#L1911