Horton

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>, Chapman Flack <chap@anastigmatix.net>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@lists.postgresql.org
Date: 2022-04-04T17:11:33Z
Lists: pgsql-hackers 
On 4/4/22 11:42 AM, Nathan Bossart wrote:
> I noticed a couple of other things that can be removed.  Since we no longer
> wait on exclusive backup mode during smart shutdown, we can change
> connsAllowed (in postmaster.c) to a boolean and remove CAC_SUPERUSER.  We
> can also remove a couple of related notes in the documentation.  I've done
> all this in the attached patch.

These changes look good to me. IMV it is a real bonus how much the state 
machine has been simplified.

I've also run this patch through the pgbackrest regression tests without 
any problems.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Remove duplicated word in comment of basebackup.c