Horton

Re: unused_oids script is broken with bsd sed

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: David Fetter <david@fetter.org>, John Naylor <jcnaylor@gmail.com>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-25T15:03:01Z
Lists: pgsql-hackers 
On 04/25/2018 04:59 PM, David Fetter wrote:
> While we're improving things, there's not really a reason this program
> should need to be run from any particular spot. It can detect where it
> is and act on that information.

+1

I would appreciate this change, and if Stats does not feel like adding 
it to his patch I can write a patch for this myself.

Andreas

Commits

  1. Blindly try to fix MSVC build's use of genbki.pl and Gen_fmgrtab.pl.

  2. Avoid overwriting unchanged output files in genbki.pl and Gen_fmgrtab.pl.

  3. Rearrange makefile rules for running Gen_fmgrtab.pl.

  4. Avoid parsing catalog data twice during BKI file construction.

  5. Fix duplicate_oids and unused_oids so user needn't cd to catalog dir.

  6. Convert unused_oids and duplicate_oids to use Catalog.pm infrastructure.

  7. Make Catalog.pm's representation of toast and index decls more abstract.