Horton

Re: [18] Unintentional behavior change in commit e9931bfb75

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2024-12-03T06:24:07Z
Lists: pgsql-hackers 
On Mon, 2024-12-02 at 17:25 -0500, Tom Lane wrote:
> Well, also for compatibility with our SQL parser's understanding
> of identifier lowercasing.

But why only for single-byte encodings? And why not for ICU?

> > Should I put the special case back?
> 
> I think so.

Done. I put the special case back in (commit e3fa2b037c) because the
earlier commit wasn't intended to be a behavior change.

I'm still not convinced that the special case behavior is great, but a
lot of users are unaffected because they are on UTF8 anyway, so I'm
fine keeping it.

Regards,
	Jeff Davis

Commits

  1. Another unintentional behavior change in commit e9931bfb75.

  2. Improve comment in regc_pg_locale.c.

  3. Fix unintentional behavior change in commit e9931bfb75.

  4. Remove support for null pg_locale_t most places.

  5. Fix up handling of C/POSIX collations.