Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: "Bossart, Nathan" <bossartn@amazon.com>,
David Steele <david@pgmasters.net>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>,
Laurenz Albe <laurenz.albe@cybertec.at>,
Michael Paquier <michael@paquier.xyz>,
Pg Hackers <pgsql-hackers@postgresql.org>,
SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: 2021-12-02T16:00:32Z
Lists: pgsql-hackers
On 12/1/21 19:30, Bossart, Nathan wrote: > On 12/1/21, 10:37 AM, "Bossart, Nathan" <bossartn@amazon.com> wrote: >> On 12/1/21, 8:27 AM, "David Steele" <david@pgmasters.net> wrote: >>> On 11/30/21 18:31, Bossart, Nathan wrote: >>>> Do you think it's still worth trying to make it safe, or do you think >>>> we should just remove exclusive mode completely? >>> My preference would be to remove it completely, but I haven't gotten a >>> lot of traction so far. >> In this thread, I count 6 people who seem alright with removing it, >> and 2 who might be opposed, although I don't think anyone has >> explicitly stated they are against it. > I hastily rebased the patch from 2018 and got it building and passing > the tests. I'm sure it will need additional changes, but I'll wait > for more feedback before I expend too much more effort on this. > Should we really be getting rid of PostgreSQL::Test::Cluster::backup_fs_hot() ? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
Commits
-
Remove duplicated word in comment of basebackup.c
- 83cca409edf2 15.0 landed