Horton

Re: Polyphase merge is obsolete

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Date: 2021-03-25T13:41:05Z
Lists: pgsql-hackers 
On 1/22/21 5:19 PM, Heikki Linnakangas wrote:
> On 22/10/2020 14:48, Heikki Linnakangas wrote:
>> On 11/09/2017 13:37, Tomas Vondra wrote:
>>> I planned to do some benchmarking on this patch, but apparently the
>>> patch no longer applies. Rebase please?
>>
>> Here's a rebase of this. Sorry to keep you waiting :-).

I am amused that the wait here was 3+ years!

> Here's an updated version that fixes one bug:

We're near the end of the CF and this has not really seen any review 
after a long hiatus. I'll move this to the next CF on April 30 unless I 
hear objections.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Fix and clarify function comment on LogicalTapeSetCreate.

  2. Refactor LogicalTapeSet/LogicalTape interface.

  3. Replace polyphase merge algorithm with a simple balanced k-way merge.

  4. logtape.c: do not preallocate for tapes when sorting