Re: [PATCH] lock_timeout and common SIGALRM framework

Boszormenyi Zoltan <zb@cybertec.at>

From: Boszormenyi Zoltan <zb@cybertec.at>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Marc Cousin <cousinmarc@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Hans-Juergen Schoenig <hs@cybertec.at>, Ants Aasma <ants@cybertec.at>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-07-04T16:58:44Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix Windows implementation of PGSemaphoreLock.

2012-07-04 17:25 keltezéssel, Alvaro Herrera írta:
> Excerpts from Boszormenyi Zoltan's message of mié jul 04 07:03:44 -0400 2012:
>> 2012-07-03 23:38 keltezéssel, Alvaro Herrera írta:
>>> I don't understand why PGSemaphoreTimedLock() is not broken.  I mean
>>> surely you need a bool return to let the caller know whether the
>>> acquisition succeeded or failed?
>> Well, this is the same interface PGSemaphoreTryLock() uses.
>> By this reasoning, it's also broken.
> Eh, no -- as far as I can see, PGSemaphoreTryLock returns a boolean,
> which is precisely my point.

You're right. I blame the heat for not being able to properly
read my own code.

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/