Horton

Re: Support for array_remove and array_replace functions

Marco Nenciarini <marco.nenciarini@2ndquadrant.it>

View thread
From: Marco Nenciarini <marco.nenciarini@2ndquadrant.it>
To: Alex Hunsaker <badalex@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-06-30T21:28:28Z
Lists: pgsql-hackers

Attachments

On 30/06/2012 04:16, Alex Hunsaker wrote:
>  
> Hi, I've been reviewing this patch.
> 
> Good documentation, and regression tests. The code looked fine but I
> didn't care for the code duplication between array_replace and
> array_remove so I merged those into a helper function,
> array_replace_internal(). Thoughts?

It looks reasonable.

There was a typo in array_replace which was caught by regression tests.
I've fixed the typo and changed a comment in array_replace_internal.

Patch v3 attached.

Regards,
Marco

-- 
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco.nenciarini@2ndQuadrant.it | www.2ndQuadrant.it