Horton

Re: Set notice receiver before libpq connection startup

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Fujii Masao <masao.fujii@gmail.com>, Rafia Sabih <rafia.pghackers@gmail.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-05-28T00:39:48Z
Lists: pgsql-hackers

Attachments


> On May 28, 2026, at 01:56, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
> On 23.05.26 01:56, Chao Li wrote:
>>> On May 22, 2026, at 23:28, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> 
>>> On Fri, May 22, 2026 at 11:56 PM Chao Li <li.evan.chao@gmail.com> wrote:
>>>> PFA v4, just removed conn NULL check.
>>> 
>>> Thanks for updating the patch! I've pushed it.
>>> 
>>> Regards,
>>> 
>>> -- 
>>> Fujii Masao
>> Thanks for pushing and still working hard during the PGConf.
> 
> The committed patch violates the .gitattributes whitespace rules:
> 
> git show --check 06a5c3cdef02
> 
> contrib/postgres_fdw/connection.c:651: indent with spaces.
> +                                                   /* expand_dbname = */ false);
> 
> It is unfortunate that pgindent produces this layout that contradicts the git configuration.  (The current formatting also doesn't look like what I would produce in an editor, so I think git is right here.)
> 
> Maybe we could reformat this slightly to avoid that?  (unless someone wants to try to fix pgindent)
> 
> 

Ah, I was not aware of the whitespace rule. I think it was not pgindent; I made that change manually. I added “=” because I thought it might read more fluently.

Attached is a fix for that.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/