Re: pg_upgrade libraries check
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-05-27T18:52:51Z
Lists: pgsql-hackers
On 05/27/2012 02:32 PM, Tom Lane wrote: > Andrew Dunstan<andrew@dunslane.net> writes: >> AIUI, for Tom's scheme to work pg_upgrade would need not to check >> libraries that belonged to extension functions. Currently it simply >> assumes that what is present in the old cluster is exactly what will be >> needed in the new cluster. Tom's proposed scheme would completely >> invalidate that assumption (which I would argue is already of doubtful >> validity). Instead of explicitly trying to LOAD the libraries it would >> have to rely on the "CREATE EXTENSION foo" failing, presumably at some >> time before it would be too late to abort. > Well, the scheme I had in mind would require pg_upgrade to verify that > the new cluster contains an extension control file for each extension in > the old cluster (which is something it really oughta do anyway, if it > doesn't already). After that, though, it ought not be looking at the > individual functions defined by an extension --- it is the extension's > business which libraries those are in. > Yeah, that makes sense. cheers andrew