Re: pg_createsubscriber: allow duplicate publication names
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>,
Shubham Khanna <khannashubham1197@gmail.com>
Date: 2026-06-09T00:38:02Z
Lists: pgsql-hackers
> On Jun 8, 2026, at 17:30, Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Wed, Jun 3, 2026 at 7:56 AM Chao Li <li.evan.chao@gmail.com> wrote: >> >>> On Jun 2, 2026, at 18:01, Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote: >>> >>> Dear Amit, >>> >>>> Can't we use --replication-slot=name to avoid this ERROR? I mean use >>>> different replication slot names. >>> >>> Are you saying the below case, right? It can work. >>> >>> ``` >>> $ pg_createsubscriber -D data_sta/ -P 'user=postgres port=5432' -d postgres --subscription sub --replication-slot=slot1 -d testdb --subscription sub --replication-slot=slot2 -U postgres >>> ``` >>> >>> BTW; slot creations are tried before the standby promotes, thus there may be a chance >>> user read the error message, change the subscription name, and retry. But I still >>> think we should guard the combination, which means it's too late for PG19. >>> >> >> Hi Hayato-san, thanks for the comment. I’ll keep it in my notes for later reference. >> >> BTW, I just saw someone has added this patch to the Open Items list. >> > > Pushed the fix. We can close the open item tomorrow morning if > buildfarm doesn't complain and we didn't see any other comments > related to this. > > -- > With Regards, > Amit Kapila. Thanks for pushing. I have moved the item to the “resolved” section. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Commits
-
pg_createsubscriber: Fix duplicate publication name rejection.
- 6ce035ffff44 19 (unreleased) landed