Re: pgsql_fdw, FDW for PostgreSQL server

Shigeru Hanada <shigeru.hanada@gmail.com>

From: Shigeru Hanada <shigeru.hanada@gmail.com>
To: Albe Laurenz <laurenz.albe@wien.gv.at>
Cc: Kohei KaiGai <kaigai@kaigai.gr.jp>, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Hitoshi Harada <umi.tanuki@gmail.com>, Martijn van Oosterhout <kleptog@svana.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-02-17T00:52:50Z
Lists: pgsql-hackers
(2012/02/17 0:15), Albe Laurenz wrote:
> Shigeru Hanada wrote:
>> Thanks for the review.  Attached patches are revised version, though
>> only fdw_helper_v5.patch is unchanged.
> 
> Two questions:
> - Is it on purpose that you can specify all SSL client options
>    except "sslcompression"?

No, just an oversight.  Good catch.

> - Since a rescan is done by rewinding the cursor, is it necessary
>    to have any other remote isolation level than READ COMMITED?
>    There is only one query issued per transaction.

If multiple foreign tables on a foreign server is used in a local query,
multiple queries are executed in a remote transaction.  So IMO isolation
levels are useful even if remote query is executed only once.

Regards,
-- 
Shigeru Hanada