Re: auto_explain produces invalid JSON

On 02/11/2012 03:22 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> But ExplainBeginOutput says:
>>        case EXPLAIN_FORMAT_JSON:
>>             /* top-level structure is an array of plans */
>>             appendStringInfoChar(es->str, '[');
>> Now that's not true in the auto-explain case, which prints one query +
>> one plan.
> What about queries that expand to multiple plans because of rules?


... and the answer is it logs them in separate pieces of JSON.

>
>> Since this is an exposed API, I don't think we can just change it. We
>> probably need a new API that does the right thing for beginning and
>> ending auto_explain output. (ExplainBeginLabeledOutput?)
> I'm inclined to think that this is auto_explain's error, not that of
> the core code, ie we should be changing the output.
>
> 			


Well, maybe this is more to your taste, although it strikes me as more 
than something of a kludge. At least it's short :-)

cheers

andrew