Re: xlog location arithmetic
Euler Taveira de Oliveira <euler@timbira.com>
From: Euler Taveira de Oliveira <euler@timbira.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>, Robert Haas <robertmhaas@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2012-02-09T22:00:30Z
Lists: pgsql-hackers
Attachments
- xlogdiff3.diff (text/x-patch) patch
On 08-02-2012 09:35, Fujii Masao wrote: Fujii, new patch attached. Thanks for your tests. > But another problem happened. When I changed pg_proc.h so that the unused > OID was assigned to pg_xlog_location_diff(), and executed the above again, > I encountered the segmentation fault: > I reproduced the problems in my old 32-bit laptop. I fixed it casting to int64. I also updated the duplicated OID. > Why OID needs to be reassigned? > There isn't a compelling reason. It is just a way to say: "hey, it is another function with the same old name". I'll not attach another version for pg_size_pretty because it is a matter of updating a duplicated OID. -- Euler Taveira de Oliveira - Timbira http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento