Re: When do we lose column names?

On 02/09/2012 02:54 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> OK, the one place that needs to be fixed to avoid the crash caused by
>> the json regression tests with the original patch is in
>>      src/backend/parser/parse_expr.c:transformRowExpr().
>> Other candidates I have found that don't set colnames and should
>> probably use dummy names are:
>>    * src/backend/parser/gram.y (row: production)
>>    * src/backend/optimizer/prep/prepunion.c:adjust_appendrel_attrs_mutator()
>>    * src/backend/optimizer/util/var.c:flatten_join_alias_vars_mutator()
> Hm, can't the last two get real column names from somewhere?

Possibly. I'll dig a bit deeper.

> Also, why
> would it be the responsibility of the grammar production to fill in the
> list, rather than transformRowExpr?
>
>


Sure. I'll just comment the source accordingly.

cheers

andrew