Re: Review of: explain / allow collecting row counts without timing info
Tomas Vondra <tv@fuzzy.cz>
From: Tomas Vondra <tv@fuzzy.cz>
To: pgsql-hackers@postgresql.org
Date: 2012-02-03T22:45:23Z
Lists: pgsql-hackers
On 3.2.2012 22:51, Robert Haas wrote: > On Fri, Feb 3, 2012 at 2:56 PM, Tomas Vondra <tv@fuzzy.cz> wrote: >> OK, thanks for the explanation. I don't like the idea of subsets as it >> IMHO makes it less obvious what options are enabled. For example this >> >> EXPLAIN (ROWS) query... >> >> does not immediately show it's actually going to do ANALYZE. > > Well, it isn't, if ANALYZE means rows + timing... Yeah, sure. It depends on how you define ANALYZE. I see that as 'stats collected at runtime' (in contrast to a query plan, which is just a ... well, plan). >> but what if someone wants both at the same time? Maybe he could do >> >> EXPLAIN (ROWS, BUFFERS) >> >> and treat that as a union of those subsets. I don't think it's worth it. > > Yeah, I forgot that we'd have to allow that, though I don't think it > would be a big deal to fix that. > >> I surely can live with both solutions (mine or the one you proposed). > > Let's wait and see if anyone else has an opinion. Sure. And thanks for your feedback! Tomas