Re: Remembering bug #6123

Kevin Grittner <kevin.grittner@wicourts.gov>

From: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
To: "Tom Lane" <tgl@sss.pgh.pa.us>
Cc: <pgsql-hackers@postgresql.org>
Date: 2012-01-12T23:29:44Z
Lists: pgsql-hackers

Attachments

Tom Lane <tgl@sss.pgh.pa.us> wrote:
 
> Hmm, I would think you'd get assertion failures from calling
> HeapTupleHeaderGetCmax when xmax isn't the current transaction.
> (But I'm not sure that the regression tests really exercise such
> cases ... did you try the isolation tests with this?)  I was
> thinking we should probably define the cmax as being returned only
> in SelfUpdated cases.
 
You were right.  One of the isolation tests failed an assertion;
things pass with the attached change, setting the cmax
conditionally.  Some comments updated.  I hope this is helpful.  I
can't take more time right now, because we're getting major snowfall
and I've got to leave now to get home safely.
 
-Kevin