Re: Remembering bug #6123

Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
 
>> Am I getting closer?
> 
> Hmm, I would think you'd get assertion failures from calling
> HeapTupleHeaderGetCmax when xmax isn't the current transaction.
> (But I'm not sure that the regression tests really exercise such
> cases ... did you try the isolation tests with this?)
 
I didn't go farther than a `make check`, but I'm doing a more
thorough set of tests now.
 
> I was thinking we should probably define the cmax as being
> returned only in SelfUpdated cases.
 
I thought about that, but didn't see how it could be other than
self-updated.  If you do, I guess I missed something.
 
> You failed to update assorted relevant comments, too.  But I can
> take it from here.
 
I can take another pass to polish it if you'd like.  I didn't expect
this to be the last version I posted; I was afraid I might still
have some restructuring to do.
 
-Kevin