Horton

Re: [patch] for "psql : Allow processing of multiple -f (file) options "

Euler Taveira de Oliveira <euler@timbira.com>

View thread
From: Euler Taveira <euler@timbira.com>
To: Vikash3 S <vikash3.s@tcs.com>
Cc: pgsql-hackers@postgresql.org
Date: 2012-04-09T13:12:36Z
Lists: pgsql-hackers 
On 09-04-2012 02:43, Vikash3 S wrote:
> Please find the patch regarding trivial changes against To Do item list for
> "psql : Allow processing of multiple -f (file) options ".
> Looking for valuable feedback.
> 
Aren't you forget to cover the single transaction (-1) mode? How would you
handle ON_ERROR_* options? Look at the archives for references. Also, your
disclaimer doesn't seems attractive; make it clear you're contributing code
under the PostgreSQL license.


-- 
   Euler Taveira de Oliveira - Timbira       http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento