Re: patch for parallel pg_dump
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Joachim Wieland <joe@mcknight.de>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-03-13T18:10:45Z
Lists: pgsql-hackers
On 03/13/2012 01:53 PM, Robert Haas wrote: >> >> I tried this actually (patch attached) but then I wanted to test it >> and couldn't find anything that used pgpipe() on Windows. >> >> pg_basebackup/pg_basebackup.c is using it but it's in an #ifndef WIN32 >> and the same is true for postmaster/syslogger.c. Am I missing >> something or has this Windows implementation become stale by now? I'll >> append the patch but haven't adapted the pg_dump patch yet to use it. >> Should we still go forward the way you proposed? > Dunno. Can we get an opinion on that from one of the Windows guys? > Andrew, Magnus? > > I haven't had time to review this patch or even follow all the discussion as I was hoping. I'll try to review the whole thing shortly. cheers andrew