Re: regress bug
Andrew Dunstan <andrew.dunstan@pgexperts.com>
From: Andrew Dunstan <andrew.dunstan@pgexperts.com>
To: "David E. Wheeler" <david@justatheory.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-03-08T20:20:59Z
Lists: pgsql-hackers
Attachments
- regress.patch (text/x-patch) patch
On 03/08/2012 02:59 PM, David E. Wheeler wrote: > On Mar 8, 2012, at 10:22 AM, Andrew Dunstan wrote: > >> This seems like an outright bug. I don't recall any discussion on it. Maybe nobody's come across it before. ISTM the correct behaviour would be to put converted sql files in $inputdir/sql and converted results files in $outputdir/expected. > In my extension distributions, I have > > tests/sql > tests/expected > > And for that, --inputdir=test works just fine. I don't mess with --outputdir, which just seems to affect where the actual output is written to, which is just a directory named regression.out at the top of the project. > It works fine if you don't need to do any file conversions (i.e. if you don't have "input" or "output" directories). But file_textarray_fdw does. Here's a patch that I think fixes the problem. cheers andrew