Re: pgsql_fdw, FDW for PostgreSQL server

Shigeru Hanada <shigeru.hanada@gmail.com>

From: Shigeru Hanada <shigeru.hanada@gmail.com>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Kohei KaiGai <kaigai@kaigai.gr.jp>, Albe Laurenz <laurenz.albe@wien.gv.at>, Martijn van Oosterhout <kleptog@svana.org>, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Hitoshi Harada <umi.tanuki@gmail.com>
Date: 2012-02-23T05:14:07Z
Lists: pgsql-hackers

Attachments

(2012/02/21 8:07), Shigeru Hanada wrote:
> Hm, agreed that isolation levels<  REPEATABLE READ are not sufficient for
> pgsql_fdw's usage.  I'll examine the example and fix pgsql_fdw.

Attached patch uses "safe" isolation level for remote transactions.
After this change, pgsql_fdw uses levels below:

      local       |     remote
------------------+-----------------
 SERIALIZABLE     | SERIALIZABLE
 REPEATABLE READ  | REPEATABLE READ
 READ COMMITTED   | REPEATABLE READ
 READ UNCOMMITTED | REPEATABLE READ

Please review document of pgsql_fdw too.

In addition, I've removed #ifdef from options.c, so that we can specify
libpq options about SSL and Kerberos even if such feature has not been
configured on the environment where pgsql_fdw was built.  This change
also avoids regression test failure on environment where any of
--with-openssl or --with-krb5 was specified for configure script.

Regards,
-- 
Shigeru Hanada