Re: Potential reference miscounts and segfaults in plpython.c
Jan Urbański <wulczer@wulczer.org>
From: Jan Urbański <wulczer@wulczer.org>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2012-02-22T12:37:25Z
Lists: pgsql-hackers
Attachments
- cpychecker-fixes-v2.patch (text/x-diff) patch v2
- cpychecker-fixes-9.1-v2.patch (text/x-diff) patch v2
On 21/02/12 18:28, Jan Urbański wrote: > On 21/02/12 18:05, Peter Eisentraut wrote: >>> it might be better to use ereport, to expose the message >>> for translation. >>> > After giving it some thought some of these elogs could be changed into > PLy_elogs (which is meant to propagate a Python error into Postgres) and > the others made into ereports. > > I'll send updated patches this evening (CET). Inevitably, this turned into the next morning CET. Here are the updated patches which use PLy_elog instead of plain elog. The difference is that they will get marked for translation and that the original Python exception will show up in the errdetail field. Cheers, Jan