Re: Review of VS 2010 support patches

Brar Piening <brar@gmx.de>

From: Brar Piening <brar@gmx.de>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: Craig Ringer <craig@postnewspapers.com.au>, PG Hackers <pgsql-hackers@postgresql.org>

Date: 2011-12-31T23:10:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Enable compiling with the mingw-w64 32 bit compiler.
- 1a0c76c32fe4 9.2.0 cited
Unify spelling of "canceled", "canceling", "cancellation"
- 21f1e15aafb1 9.2.0 cited

Attachments

VS2010v12.patch (text/plain) patch

Brar Piening wrote:
> Andrew Dunstan wrote:
>> Can you narrow down exactly what in that commit broke VS 2010? Are 
>> there any compiler warnings?
>
> I was able to nail down the problem.

In the absence of reaction, to keep my promise, I'm sending the attached 
Patch which restores the previous working behaviour for Visual Studio 2011.
Note however that it also restores the previous conflicts with errno.h 
which aren't neccessarily a problem, but might be in future.

Regards,

Brar