Horton

Re: [PATCH] Caching for stable expressions with constant arguments v3

Greg Smith <greg@2ndquadrant.com>

View thread
From: Greg Smith <greg@2ndQuadrant.com>
To: Marti Raudsepp <marti@juffo.org>
Cc: Jaime Casanova <jaime@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2011-12-16T07:13:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. include_if_exists facility for config file.

I think what would be helpful here next is a self-contained benchmarking 
script.  You posted an outline of what you did for the original version 
at 
http://archives.postgresql.org/message-id/CABRT9RC-1wGxZC_Z5mwkdk70fgY2DRX3sLXzdP4voBKuKPZDow@mail.gmail.com

It doesn't sound like it would be hard to turn that into a little shell 
script.  I'd rather see one from you mainly so I don't have to worry 
about whether I duplicated your procedure correctly or not.  Don't even 
worry about "best of 3", just run it three times, grep out the line that 
shows the TPS number, and show them all.  One of the first questions I 
have is whether the performance changed between there and your v5.  A 
self-contained and fully automated performance test case would ease 
review, and give some performance regression testing for other suggested 
changes to use as a reference.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us