Re: includeifexists in configuration file

Greg Smith <greg@2ndquadrant.com>

From: Greg Smith <greg@2ndQuadrant.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-12-16T06:02:06Z
Lists: pgsql-hackers
On 12/15/2011 08:16 PM, Andrew Dunstan wrote:
>  I changed the elog() call to use ereport(): you're not supposed to 
> use elog() for things we expect might well happen and cause log 
> entries - see bottom of 
> <http://www.postgresql.org/docs/current/static/error-message-reporting.html>. 
> I've probably been guilty of this in the past, it's a bit too easy to 
> forget.

Quite, I both knew this once and forgot it last night.  There was some 
nagging in the back of my head that I was doing something wrong, but I 
couldn't place what.  Happy this is committed, given that I've suggested 
relying upon it in the recovery.conf thread.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us