Horton

Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-12-14T20:34:23Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove troublesome Asserts in cost_mergejoin().

  2. Enable building with the Mingw64 compiler.


On 12/14/2011 03:09 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>>      +  # Disable FP optimizations that cause isinf errors on gcc 4.5+
>>      +  PGAC_PROG_CC_CFLAGS_OPT([-fexcess-precision=standard])
> Looks sane to me, except "isinf errors" is an awfully narrow reading of
> the problem.  Maybe just say "assorted errors"?  Also, do we know that
> gcc 4.5 poses the issue?  I'm only aware of reports for 4.6 and 4.7.


It looked to me like this switch landed in gcc 4.5 because they were 
getting problems like this. See 
<http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00105.html>


>> I guess we should backpatch it?
> +1.  Back branches will see these same problems as soon as anybody
> tries to compile them with latest-n-greatest gcc.
>
> 			


Yeah. Will do.

cheers

andrew