Horton

Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>, pgsql-committers@postgresql.org
Date: 2011-11-26T13:20:24Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Modify pg_dump to use error-free memory allocation macros. This avoids


On 11/26/2011 02:13 AM, Tom Lane wrote:
> Bruce Momjian<bruce@momjian.us>  writes:
>> Modify pg_dump to use error-free memory allocation macros.  This avoids
>> ignoring errors and call-site error checking.
> This appears to have broken the MSVC build.  More generally, I'd like to
> object to arbitrarily moving a bunch of longstanding code from one file
> to another.  What that is mainly going to accomplish is creating a big
> headache whenever we have to back-patch fixes that touch that code
> ... and what exactly did it buy in return?
>
> 			


Was there any discussion of this change? It seems much too big for 
something to be done without discussion, but I don't recall seeing 
anything. (And it's probably seriously broken two patches I have in the 
commitfest).

cheers

andrew