Re: SQLDA fix for ECPG
Boszormenyi Zoltan <zb@cybertec.at>
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development Hackers <pgsql-hackers@postgresql.org>, Michael Meskes <meskes@postgresql.org>
Date: 2011-11-14T08:06:30Z
Lists: pgsql-hackers
Attachments
- ecpg-sqlda-part2.patch (text/plain) patch
2011-11-13 17:27 keltezéssel, Tom Lane írta:
> Boszormenyi Zoltan <zb@cybertec.at> writes:
>> I had a report about ECPG code crashing which involved
>> a query using a date field. Attached is a one liner fix to make
>> the date type's offset computed consistently across
>> sqlda_common_total_size(), sqlda_compat_total_size() and
>> sqlda_native_total_size().
> Is this really the only issue there? I notice discrepancies among those
> three routines for some other types too, notably ECPGt_timestamp and
> ECPGt_interval.
>
> regards, tom lane
Yes, you are right. For timestamp and interval, the safe alignment is int64.
Patch is attached.
Best regards,
Zoltán Böszörményi
--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/