Re: DatumGetInetP buggy
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Hans-Juergen Schoenig <hs@cybertec.at>, Leonardo Bispo de Oliveira <leonardo.oliveira@voipfuture.com>
Date: 2011-11-08T20:52:43Z
Lists: pgsql-hackers
On 08.11.2011 20:46, Boszormenyi Zoltan wrote: > 2011-11-08 18:53 keltezéssel, Heikki Linnakangas írta: >> What do people think of backpatching this? I'm inclined to backpatch, on the grounds >> that the macro that detoasts and depacks should always work (ie. after this patch), even >> if the depacking isn't necessary and introduces an extra palloc+copy, but the reverse is >> not true. > > On the grounds that 9.0.x also shows the problem with > the stock macro, backporting would be nice. I don't know > which older trees may show the problem, I only tested with > 9.0 and 9.1. Packed varlenas were introduced in 8.3 - this hasn't changed since then. Committed and backpatched all the way to 8.3. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com