Re: WIP: Fast GiST index build
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-07-28T21:10:21Z
Lists: pgsql-hackers
On 28.07.2011 23:57, Alexander Korotkov wrote: > On Tue, Jul 26, 2011 at 9:24 PM, Heikki Linnakangas< > heikki.linnakangas@enterprisedb.com> wrote: >> >> Let me know if you have questions on the approach taken. > > > I realized that approach which comes as replace to loaded-subtrees keeping > is unclear to me. We save paths between node buffers. But those paths can > become invalid on page splits. It seems to me that approximately same volume > of code for maintaining parent links should be added to this version of > patch in order to get it working correctly. gistFindCorrectParent() should take care of that. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com