Horton

Re: libpq SSL with non-blocking sockets

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Geoghegan <peter@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Martin Pihlak <martin.pihlak@gmail.com>, Steve Singer <ssinger_pg@sympatico.ca>, Robert Haas <robertmhaas@gmail.com>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2011-07-25T00:55:51Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve libpq's error reporting for SSL failures.

  2. Use OpenSSL's SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER flag.


On 07/24/2011 07:49 PM, Peter Geoghegan wrote:
> On 24 July 2011 21:33, Tom Lane<tgl@sss.pgh.pa.us>  wrote:
>> I've applied the simplified fix (just set SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER)
>> as well as a patch to improve the error reporting situation.
> I'm not exactly sure why, and don't have time to investigate right
> now, but this commit (fee476da952a1f02f7ccf6e233fb4824c2bf6af4)
> appears to have broken the build for me:
>
>

Yeah, looks like it fails unless --with-openssl is set.

cheers

andrew