Re: Re: patch review : Add ability to constrain backend temporary file space
Mark Kirkwood <mark.kirkwood@catalyst.net.nz>
From: Mark Kirkwood <mark.kirkwood@catalyst.net.nz>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: josh@agliodbs.com, cedric.villemain.debian@gmail.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2011-07-14T10:34:30Z
Lists: pgsql-hackers
On 14/07/11 18:48, Tatsuo Ishii wrote: > > Hi I am the new reviewer:-) > > I have looked into the v6 patches. One thing I would like to suggest > is, enhancing the error message when temp_file_limit will be exceeded. > > ERROR: aborting due to exceeding temp file limit > > Is it possible to add the current temp file limit to the message? For > example, > > ERROR: aborting due to exceeding temp file limit 10000kB > > I know the current setting of temp_file_limit can be viewd in other > ways, but I think this will make admin's or application developer's > life a little bit easier. Hi Tatsuo, Yeah, good suggestion - I agree that it would be useful to supply extra detail, I'll amend and resubmit a new patch (along with whatever review modifications we come up with in the meantime)! Cheers Mark