Horton

Re: Small patch for GiST: move childoffnum to child

Josh Berkus <josh@agliodbs.com>

View thread
From: Josh Berkus <josh@agliodbs.com>
To: pgsql-hackers@postgresql.org
Cc: Teodor Sigaev <teodor@sigaev.ru>, Oleg Bartunov <oleg@sai.msu.su>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Date: 2011-07-10T18:43:14Z
Lists: pgsql-hackers 
Teodor, Oleg, Heikki,

> My concern is that I am unable to prove to myself simply by reading
> the code that the 24 line chunk deleted from gistFindPath (near ***
> 919,947 ****) are no longer needed.  My familiarity with the gist code
> is low enough that it is not surprising that I cannot prove this to
> myself from first principles.  I have no reason to believe it is not
> correct, it is just that I can't convince myself that it is correct.

Can one of you weigh in on Jeff's concern here about this patch?

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com