Re: Latch implementation that wakes on postmaster death on both win32 and Unix

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Peter Geoghegan <peter@2ndquadrant.com>, PG Hackers <pgsql-hackers@postgresql.org>, Florian Pflug <fgp@phlo.org>
Date: 2011-06-30T07:58:01Z
Lists: pgsql-hackers

Attachments

On 30.06.2011 09:36, Fujii Masao wrote:
> On Sat, Jun 25, 2011 at 10:41 AM, Peter Geoghegan<peter@2ndquadrant.com>  wrote:
>> Attached is patch that addresses Fujii's third and most recent set of concerns.
>
> Thanks for updating the patch!
>
>> I think that Heikki is currently taking another look at my work,
>> because he indicates in a new message to the list a short time ago
>> that while reviewing my patch, he realised that there may be an
>> independent problem with silent_mode. I will wait for his remarks
>> before producing another version of the patch that incorporates those
>> two small changes.
>
> Yes, we should wait for the comments from Heikki. But, I have another
> comments;

Here's a WIP patch with some mostly cosmetic changes I've done this far. 
I haven't tested the Windows code at all yet. It seems that no-one is 
objecting to removing silent_mode altogether, so I'm going to do that 
before committing this patch.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com