Re: Double sorting split patch

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

To: Alexander Korotkov <aekorotkov@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2011-10-06T10:19:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix contrib/seg's GiST picksplit method.
- 2a6ebe70fb2f 9.1.0 cited
Some copy editing of pg_read_binary_file() patch.
- 290f1603b420 9.1.0 cited

On 06.10.2011 11:22, Alexander Korotkov wrote:
> Thanks. I'm going to continue work on application of this split method in
> following areas:
> 1) range types
> 2) seg contrib module
> 3) cube contrib module (there situation is not so easy, probably some
> heuristic of split method selection would be required)
> Do you think that separation of some common parts of algorithm implemetation
> is resonable in order to avoid code duplication? For example, different
> application of algorithm could share function of splits enumeration along
> axis which takes pointer to consider_split as an argument.

Dunno. I'd suggest that you just copy-paste the code for now, and we'll 
see how much duplication there is in the end.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com