Horton

Re: Double sorting split patch

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-09-22T11:22:36Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix contrib/seg's GiST picksplit method.

  2. Some copy editing of pg_read_binary_file() patch.

> ! 		/*
> ! 		 * Calculate delta between penalties of join "common entries" to
> ! 		 * different groups.
> ! 		 */
> ! 		for (i = 0; i < commonEntriesCount; i++)
>   		{
> ! 			double		lower,
> ! 						upper;
> !
> ! 			box = DatumGetBoxP(entryvec->vector[commonEntries[i].index].key);
> ! 			if (context.dim == 0)
> ! 			{
> ! 				lower = box->low.x;
> ! 				upper = box->high.x;
> ! 			}
> ! 			else
> ! 			{
> ! 				lower = box->low.y;
> ! 				upper = box->high.y;
> ! 			}
> ! 			commonEntries[i].delta = Abs(box_penalty(leftBox, box) -
> ! 										 box_penalty(rightBox, box));
>   		}

'lower' and 'upper' are not used for anything in the above. Is that just 
dead code that can be removed, or is there something missing that should 
be using them?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com