Horton

Re: unite recovery.conf and postgresql.conf

Euler Taveira de Oliveira <euler@timbira.com>

View thread
From: Euler Taveira de Oliveira <euler@timbira.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter_e@gmx.net>, Simon Riggs <simon@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-09-16T13:46:35Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Restructure error handling in reading of postgresql.conf.

On 15-09-2011 23:54, Fujii Masao wrote:
> #1
> Use empty recovery.ready file to enter arhicve recovery. recovery.conf
> is not read automatically. All recovery parameters are expected to be
> specified in postgresql.conf. If you must specify them in recovery.conf,
> you need to add "include 'recovery.conf'" into postgresql.conf. But note
> that that recovery.conf will not be renamed to recovery.done at the
> end of recovery. This is what the patch I've posted does. This is
> simplest approach, but might confuse people who use the tools which
> depend on recovery.conf.
>
more or less +1. We don't need two config files.; just one: postgresql.conf. 
Just turn all recovery.conf parameters to GUCs. As already said, the 
recovery.conf settings are not different from archive settings, we just need a 
way to trigger the recovery. And that trigger could be pulled by a GUC 
(standby_mode) or a file (say recovery -> recovery.done). Also, recovery.done 
could be filled with recovery information just for DBA record. standby_mode 
does not create any file, it just trigger the recovery (as it will be used 
mainly for replication purposes).


-- 
    Euler Taveira de Oliveira - Timbira       http://www.timbira.com.br/
    PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento