Horton

RE: ON CONFLICT DO NOTHING on pg_dump

Ideriha, Takeshi <ideriha.takeshi@jp.fujitsu.com>

View thread View on postgr.es
From: "Ideriha, Takeshi" <ideriha.takeshi@jp.fujitsu.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Surafel Temesgen <surafel3000@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2018-07-13T00:33:31Z
Lists: pgsql-hackers 
Hi, thanks for the revision.

>
>+        Add ON CONFLICT DO NOTHING clause in the INSERT commands.
>
>I think this would be better as: Add <literal>ON CONFLICT DO NOTHING</literal> to
><command>INSERT</command> commands.

Agreed.

>+    printf(_("  --on-conflict-do-nothing     dump data as INSERT
>commands with ON CONFLICT DO NOTHING \n"));
>
>That's slightly misleading... let's just use the same wording again, eg "add ON
>CONFLICT DO NOTHING to INSERT commands".

Agreed. But you forgot fixing it at pg_dump.c.
So could you please fix this and commit it?

Regards,
Takeshi Ideriha

Commits

  1. Add pg_dump --on-conflict-do-nothing option.