RE: ON CONFLICT DO NOTHING on pg_dump

Ideriha, Takeshi <ideriha.takeshi@jp.fujitsu.com>

From: "Ideriha, Takeshi" <ideriha.takeshi@jp.fujitsu.com>
To: Nico Williams <nico@cryptonector.com>, Surafel Temesgen <surafel3000@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-26T10:14:37Z
Lists: pgsql-hackers
>> I agree with you though supporting MERGE or ON-CONFLICT-DO-UPDATE seems
>hard work.
>> Only ON-CONCLICT-DO-NOTHING use case may be narrow.
>
>Is it narrow, or is it just easy enough to add quickly?

Sorry for late replay.
I read your comment and rethought about it.
What I meant by "narrow" is that the number of people who use this new feature seems limited to me.
And I had a wrong impression that small improvements are always rejected by hackers.
But that's only the case for small improvements with huge source code modification. In short, cost/benefit ratio is low case.

This patch have some benefits with source code change is small.
So I just wait for other people reviews.

>And by the way, you don't need MERGE.  You can just generate INSERT/
>UPDATE/DELETE statements -- MERGE is mainly an optimization on that, and could
>wait until PG has a MERGE.
Oh, thank you for clarifying this. Now I understand it.

Best regards,
Takeshi Ideriha




Commits

  1. Add pg_dump --on-conflict-do-nothing option.