Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread

From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Alexander Korotkov <aekorotkov@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2011-08-09T10:25:23Z

Lists: pgsql-hackers

Attachments

string-relopt-1.patch (text/x-diff)

On 08.08.2011 22:11, Alvaro Herrera wrote:
> Perhaps the easiest way to fix it is as you suggest, by declaring the
> struct to take a pointer rather than the value directly.  Not sure how
> to make both cases work sanely; the add_string_reloption path will need
> updates.

Agreed, I propose the attached patch to do that. Are there any 
extensions out there that use add_string_relopt(), that I could use for 
testing?

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com