Horton

Re: SIREAD lock versus ACCESS EXCLUSIVE lock

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

View thread
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: simon@2ndquadrant.com, drkp@csail.mit.edu, pgsql-hackers@postgresql.org, tgl@sss.pgh.pa.us
Date: 2011-06-07T17:10:12Z
Lists: pgsql-hackers 
On 07.06.2011 20:03, Kevin Grittner wrote:
> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com>  wrote:
>
>> We've also already removed the reserved entry for scratch space
>
> This and Tom's concerns have me wondering if we should bracket the
> two sections of code where we use the reserved lock target entry
> with HOLD_INTERRUPTS() and RESUME_INTERRUPTS().

That's not necessary. You're holding a lwlock, which implies that 
interrupts are held off already. There's a HOLD_INTERRUPTS() call in 
LWLockAcquire and RESUME_INTERRUPTS() in LWLockRelease.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com