Re: Error in PQsetvalue

Andrew Chernow <ac@esilo.com>

View thread

From: Andrew Chernow <ac@esilo.com>

To: Merlin Moncure <mmoncure@gmail.com>

Cc: Pavel Golub <pavel@microolap.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-06-04T02:26:26Z

Lists: pgsql-hackers

Attachments

PQsetvalue.patch (text/x-patch) patch

>> I disagree -- I think the fix is a one-liner. line 446:
>> if (tup_num == res->ntups&& !res->tuples[tup_num])
>>
>> should just become
>> if (tup_num == res->ntups)
>>
>> also the memset of the tuple slots when the slot array is expanded can
>> be removed. (in addition, the array tuple array expansion should
>> really be abstracted, but that isn't strictly necessary here).
>>
>
> All true. This is a cleaner fix to something that was in fact broken ;) You want

Attached a patch that fixes the OP's issue.  PQsetvalue now uses pqAddTuple to 
grow the tuple table and has removed the remnants of an older idea that caused 
the bug.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/