Horton

Re: Please test peer (socket ident) auth on *BSD

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Marko Kreen <markokr@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Greg Stark <gsstark@mit.edu>, Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>, Bruce Momjian <bruce@momjian.us>
Date: 2011-06-02T17:15:07Z
Lists: pgsql-hackers 

On 06/02/2011 01:04 PM, Alvaro Herrera wrote:
> Excerpts from Marko Kreen's message of jue jun 02 12:45:04 -0400 2011:
>> On Thu, Jun 2, 2011 at 7:31 PM, Alvaro Herrera
>> <alvherre@commandprompt.com>  wrote:
>>> Excerpts from Andrew Dunstan's message of jue jun 02 11:59:02 -0400 2011:
>>>> On 06/02/2011 11:29 AM, Marko Kreen wrote:
>>>>> As there was no going back now, I even touched msvc.pm.
>>>> Why? Windows doesn't have Unix domain sockets at all.
>>> So much for being thorough :-P
>> Well, there is 2 approaches to portable C code:
>> 1) You #ifdef the main code portable
>> 2) You #ifdef common platform in headers, then main code
>> is written against common platform, without ifdefs.
>>
>> I'm from the camp #2.
> I don't disagree, just saying that you seem to have gone out of your way
> to produce something that doesn't seem to be necessary.

Yeah, I'm from the camp that says "don't compile code that's guaranteed 
to be dead."

cheers

andrew