Thread

1. Change 'pg_ctl: no server running' Exit Status to 3

   Aaron W. Swenson <aaron.w.swenson@gmail.com> — 2011-05-24T00:50:53Z

   -----BEGIN PGP SIGNED MESSAGE-----
   Hash: SHA256
   
   According to Linux Standard Base Core Specification 3.1 [1], the exit
   status should be '3' when the server isn't running.
   
   I've attached a very simple patch that resolves this cosmetic issue,
   which applies to all branches.
   
   My initial search regarding other platforms has turned up nil. It looks
   like they just check for a zero or non-zero exit status.
   
   As for the necessity of the patch: Gentoo Linux uses pg_ctl in all of
   its initscript actions for PostgreSQL. I'd imagine that Gentoo is not
   the only distribution that takes advantage of pg_ctl for its initscript
   actions.
   
   Sincerely,
       Mr. Aaron W. Swenson
   
   [1]
   http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
   -----BEGIN PGP SIGNATURE-----
   Version: GnuPG v2.0.17 (GNU/Linux)
   Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
   
   iF4EAREIAAYFAk3bAO0ACgkQCOhwUhu5AElmsQEAs5rqihVYnglG1l8tiAVE7LZ+
   vGq8+YFxRrqlPEt0kQIA/0PIdnf9xlnNewPCZuMRk/uOOeMHBptcDMSTuaWI3QBU
   =td0Z
   -----END PGP SIGNATURE-----
   

2. Re: Change 'pg_ctl: no server running' Exit Status to 3

   Robert Haas <robertmhaas@gmail.com> — 2011-06-03T16:11:30Z

   On Mon, May 23, 2011 at 8:50 PM, Aaron W. Swenson
   <aaron.w.swenson@gmail.com> wrote:
   > -----BEGIN PGP SIGNED MESSAGE-----
   > Hash: SHA256
   >
   > According to Linux Standard Base Core Specification 3.1 [1], the exit
   > status should be '3' when the server isn't running.
   >
   > I've attached a very simple patch that resolves this cosmetic issue,
   > which applies to all branches.
   >
   > My initial search regarding other platforms has turned up nil. It looks
   > like they just check for a zero or non-zero exit status.
   >
   > As for the necessity of the patch: Gentoo Linux uses pg_ctl in all of
   > its initscript actions for PostgreSQL. I'd imagine that Gentoo is not
   > the only distribution that takes advantage of pg_ctl for its initscript
   > actions.
   
   I'd be disinclined to back-patch this as it might break things for
   people.  But I see no harm in applying it to master, if nobody
   objects...
   
   -- 
   Robert Haas
   EnterpriseDB: http://www.enterprisedb.com
   The Enterprise PostgreSQL Company
   
   

3. Re: Change 'pg_ctl: no server running' Exit Status to 3

   Peter Eisentraut <peter_e@gmx.net> — 2011-06-03T20:09:00Z

   On mån, 2011-05-23 at 20:50 -0400, Aaron W. Swenson wrote:
   > According to Linux Standard Base Core Specification 3.1 [1], the exit
   > status should be '3' when the server isn't running.
   > 
   > I've attached a very simple patch that resolves this cosmetic issue,
   > which applies to all branches.
   
   If we're going to make the exit status meaningful, it should probably be
   added to the documentation.
   
   
   
   

4. Re: Change 'pg_ctl: no server running' Exit Status to 3

   Bruce Momjian <bruce@momjian.us> — 2011-10-13T17:02:40Z

   Peter Eisentraut wrote:
   > On m?n, 2011-05-23 at 20:50 -0400, Aaron W. Swenson wrote:
   > > According to Linux Standard Base Core Specification 3.1 [1], the exit
   > > status should be '3' when the server isn't running.
   > > 
   > > I've attached a very simple patch that resolves this cosmetic issue,
   > > which applies to all branches.
   > 
   > If we're going to make the exit status meaningful, it should probably be
   > added to the documentation.
   
   Patch attached and applied, with docs.  I also cleaned up some C
   comments, which are not in the attached patch.
   
   -- 
     Bruce Momjian  <bruce@momjian.us>        http://momjian.us
     EnterpriseDB                             http://enterprisedb.com
   
     + It's impossible for everything to be true. +