Horton

Re: pgindent weirdness

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2011-04-20T21:05:51Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Latest consolidated typedef list from buildfarm.


On 04/20/2011 04:28 PM, Bruce Momjian wrote:
> So the list of possible additions Andrew supplied are cases where we
> never reference those typedefs --- seems like a cleanup opportunity.
>

I think the best cleanup idea is Aidan's, namely is we have declared 
"typdef struct foo { ... } foo;" we should use "foo" in the code  
instead of "struct foo". Then the typedef will be referenced, and the 
code will be cleaner, and we won't run into the pgindent "struct" bug 
either, so it's a win/win/win.

cheers

andrew